Module:File link - Revision history

>MusikAnimal: Undid revision 948472508 by w>IPad365 (talk)

2020-04-01T06:31:54Z

Undid revision 948472508 by [[Special:Contributions/w>IPad365|w>IPad365]] ([[User talk:w>IPad365|talk]])

← Older revision		Revision as of 06:31, 1 April 2020
Line 1:		Line 1:
	-- This module provides a library for formatting file wikilinks~~. It implements {{file link}}~~.		-- This module provides a library for formatting file wikilinks.

	local yesno = require('Module:Yesno')		local yesno = require('Module:Yesno')

>MusikAnimal: 1 revision imported

2020-04-01T06:12:43Z

1 revision imported

← Older revision	Revision as of 06:12, 1 April 2020
(No difference)

w>IPad365 at 03:03, 23 September 2019

2019-09-23T03:03:29Z

← Older revision		Revision as of 03:03, 23 September 2019
Line 1:		Line 1:
	-- This module provides a library for formatting file wikilinks.		-- This module provides a library for formatting file wikilinks. It implements {{file link}}.

	local yesno = require('Module:Yesno')		local yesno = require('Module:Yesno')

>Mr. Stradivarius: when calling this from wikitext use a more readable error message for missing file parameters

2014-12-18T14:05:07Z

when calling this from wikitext use a more readable error message for missing file parameters

← Older revision		Revision as of 14:05, 18 December 2014
Line 84:		Line 84:
	wrappers = 'Template:File link'		wrappers = 'Template:File link'
	})		})
			if not origArgs.file then
			error("'file' parameter missing from [[Template:File link]]", 0)
			end

	-- Copy the arguments that were passed to a new table to avoid looking up		-- Copy the arguments that were passed to a new table to avoid looking up
	-- every possible parameter in the frame object.		-- every possible parameter in the frame object.

>Mr. Stradivarius: use yesno to test whether to add a border

2014-12-18T13:24:28Z

use yesno to test whether to add a border

← Older revision		Revision as of 13:24, 18 December 2014
Line 1:		Line 1:
	-- This module provides a library for formatting file wikilinks.		-- This module provides a library for formatting file wikilinks.

			local yesno = require('Module:Yesno')
	local checkType = require('libraryUtil').checkType		local checkType = require('libraryUtil').checkType

Line 57:		Line 58:
	end		end

	~~addPositional~~('border')		-- Border
			if yesno(args.border) then
			ret[#ret + 1] = 'border'
			end

	addPositional('location')		addPositional('location')
	addPositional('alignment')		addPositional('alignment')

>Mr. Stradivarius: make this a lot simpler - the original module was overkill for what it was trying to do

2014-12-18T12:32:08Z

make this a lot simpler - the original module was overkill for what it was trying to do

Show changes

>Mr. Stradivarius: Undid revision 611451330 by Mr. Stradivarius (talk) whoops, that edit was supposed to be to the sandbox...

2014-06-04T00:06:16Z

Undid revision 611451330 by Mr. Stradivarius (talk) whoops, that edit was supposed to be to the sandbox...

@@ Line 5: / Line 5: @@
 local fileLink = {}
 function fileLink.new(filename)
@@ Line 64: / Line 52: @@
 	end
-	local function validateSize(method, px)
+	local function sizeError(methodName)
-		-- Validate input for size-related functions. The px type is checked
+		-- Used for formatting duplication errors in size-related methods.
-		-- using checkTypeStringOrNum, so will be a string, a number, or nil.
+		error(string.format(
-		if px and data.isUpright then
+			"duplicate size argument detected in '%s'"
-			error(string.format(
+			.. " ('upright' cannot be used in conjunction with height or width)",
-				"duplicate size argument detected in '%s' ('upright' cannot be"
+			methodName
-					.. ' used in conjunction with height or width)',
+		), 3)
 	end
 	function data:width(px)
 		checkSelf(self, 'width')
-		checkTypeStringOrNum('fileLink:width', 1, px)
+		checkType('fileLink:width', 1, px, 'number', true)
-		px = validateSize('fileLink:width', px)
+		if px and data.isUpright then
 		data.theWidth = px
 		return self
@@ Line 107: / Line 73: @@
 	function data:height(px)
 		checkSelf(self, 'height')
-		checkTypeStringOrNum('fileLink:height', 1, px)
+		checkType('fileLink:height', 1, px, 'number', true)
-		px = validateSize('fileLink:height', px)
+		if px and data.isUpright then
 		data.theHeight = px
 		return self
@@ Line 217: / Line 185: @@
 		data.theLang = s
 		return self
 	end

>Mr. Stradivarius: allow specifying height and width values as strings ending in px

2014-06-04T00:05:16Z

allow specifying height and width values as strings ending in px

@@ Line 5: / Line 5: @@
 local fileLink = {}
 function fileLink.new(filename)
@@ Line 52: / Line 64: @@
 	end
-	local function sizeError(methodName)
+	local function validateSize(method, px)
-		-- Used for formatting duplication errors in size-related methods.
+		-- Validate input for size-related functions. The px type is checked
-		error(string.format(
+		-- using checkTypeStringOrNum, so will be a string, a number, or nil.
-			"duplicate size argument detected in '%s'"
+		if px and data.isUpright then
-			.. " ('upright' cannot be used in conjunction with height or width)",
+			error(string.format(
-			methodName
+				"duplicate size argument detected in '%s' ('upright' cannot be"
-		), 3)
+					.. ' used in conjunction with height or width)',
 	end
 	function data:width(px)
 		checkSelf(self, 'width')
-		checkType('fileLink:width', 1, px, 'number', true)
+		checkTypeStringOrNum('fileLink:width', 1, px)
-		if px and data.isUpright then
+		px = validateSize('fileLink:width', px)
 		data.theWidth = px
 		return self
@@ Line 73: / Line 107: @@
 	function data:height(px)
 		checkSelf(self, 'height')
-		checkType('fileLink:height', 1, px, 'number', true)
+		checkTypeStringOrNum('fileLink:height', 1, px)
-		if px and data.isUpright then
+		px = validateSize('fileLink:height', px)
 		data.theHeight = px
 		return self
@@ Line 185: / Line 217: @@
 		data.theLang = s
 		return self
 	end

>Mr. Stradivarius: Protected Module:File link: High-risk Lua module ([Edit=Allow only template editors and admins] (indefinite) [Move=Allow only template editors and admins] (indefinite))

2014-06-03T08:57:49Z

Protected Module:File link: High-risk Lua module ([Edit=Allow only template editors and admins] (indefinite) [Move=Allow only template editors and admins] (indefinite))

← Older revision	Revision as of 08:57, 3 June 2014
(No difference)

>Mr. Stradivarius: add start, end, and thumbtime

2014-05-31T14:59:01Z

add start, end, and thumbtime

@@ Line 184: / Line 184: @@
 		checkType('fileLink:lang', 1, s, 'string', true)
 		data.theLang = s
 		return self
 	end
@@ Line 236: / Line 269: @@
 		-- Render named parameters.
-		-- That includes link, alt, page, class, and lang.
+		-- That includes link, alt, page, class, lang, start, end, and thumbtime.
 		do
-			local namedParameters = {'link', 'alt', 'page', 'class', 'lang'}
+			local namedParameters = {
-			for i, parameter in ipairs(namedParameters) do
+				{'link', 'theLink'},
-				local dataField = 'the' .. parameter:sub(1, 1):upper() .. parameter:sub(2, -1)
+				{'alt', 'theAlt'},
-				local value = data[dataField]
+				{'page', 'thePage'},
 				if value then
 					ret[#ret + 1] = parameter .. '=' .. tostring(value)